Skip to content

Remove the unused structure PendingWorkloadsSummaryList#2528

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
highpon:fix/delete-unused-structure
Jul 4, 2024
Merged

Remove the unused structure PendingWorkloadsSummaryList#2528
k8s-ci-robot merged 2 commits into
kubernetes-sigs:mainfrom
highpon:fix/delete-unused-structure

Conversation

@highpon
Copy link
Copy Markdown
Member

@highpon highpon commented Jul 3, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

The PendingWorkloadsSummary struct is defined but not actually used, so I have removed it.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 3, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 3, 2024

Welcome @highpon!

It looks like this is your first PR to kubernetes-sigs/kueue 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kueue has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 3, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 3, 2024

Hi @highpon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot requested review from denkensk and kerthcet July 3, 2024 17:05
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 3, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 2db6c62
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/668680454458e50008aafcd5

@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Jul 3, 2024

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 3, 2024
mbobrovskyi
mbobrovskyi reviewed Jul 3, 2024
View reviewed changes
Comment thread apis/visibility/v1alpha1/openapi/zz_generated.openapi.go Outdated
Comment thread apis/visibility/v1alpha1/openapi/zz_generated.openapi.go Outdated
@highpon highpon requested a review from mbobrovskyi July 4, 2024 10:58
@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Jul 4, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2024
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 4, 2024

LGTM label has been added.

DetailsGit tree hash: a129770ae9d7e668832309cbdb4d42a4878b0a9a

@mbobrovskyi
Copy link
Copy Markdown
Contributor

mbobrovskyi commented Jul 4, 2024

/assign @alculquicondor

@alculquicondor
Copy link
Copy Markdown
Contributor

alculquicondor commented Jul 4, 2024

FYI @PBundyra

/lgtm
/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, highpon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 6fb993a into kubernetes-sigs:main Jul 4, 2024
@k8s-ci-robot k8s-ci-robot added this to the v0.8 milestone Jul 4, 2024
@highpon highpon deleted the fix/delete-unused-structure branch July 4, 2024 14:52
@highpon highpon mentioned this pull request Jul 30, 2024
Closed
11 tasks
kannon92 pushed a commit to openshift-kannon92/kubernetes-sigs-kueue that referenced this pull request Nov 19, 2024
@highpon @kannon92
Remove the unused structure PendingWorkloadsSummaryList (kubernetes-s…
018209c 
…igs#2528)

* Remove the unused structure PendingWorkloadsSummaryList

* fix: delete invalid comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@denkensk denkensk Awaiting requested review from denkensk

@kerthcet kerthcet Awaiting requested review from kerthcet

@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@alculquicondor alculquicondor

@mbobrovskyi mbobrovskyi

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v0.8

Development

Successfully merging this pull request may close these issues.

4 participants

@highpon @k8s-ci-robot @mbobrovskyi @alculquicondor